rewrite-clj

https://github.com/clj-commons/rewrite-clj
snoe 2020-06-25T14:48:55.063700Z

@lee was clojure-lsp a dropin replacement of rewrite-cljc then?

lread 2020-06-25T14:56:26.066200Z

If you ignore the hacks I did due to the fact that rewrite-cljc is not up on clojars yet.

snoe 2020-06-25T15:14:22.067300Z

beauty! I actually vendor rewrite-clj so I'm gonna convert this weekend. Amazing work and dedication on this project, thank you!

lread 2020-06-25T15:15:32.068400Z

You might want to wait until this is up on clojars... but... up to you! ๐Ÿ™‚

borkdude 2020-06-25T15:19:03.072800Z

snoe: fyi, I've also vendored rewrite-clj, for 3 reasons: 1) I didn't want to deal with whitespace because I'm only linting (for you this is different, since you actually rewrite). 2) fixed bugs (namespaced maps, maybe some others) 3) I wanted to deal differently with metadata nodes: I wanted metadata to be a child of a node, not a parent.

borkdude 2020-06-25T15:19:41.073400Z

however, I might include the "real" rewrite-clj as well in the future, if actually want to rewrite something like clj-kondo config. who knows

borkdude 2020-06-25T15:20:06.073800Z

anyway, I'm very excited about rewrite-cljc โค๏ธ

borkdude 2020-06-25T15:21:42.075300Z

I also volunteer as co-maintainer if you want

borkdude 2020-06-25T15:22:09.075800Z

(as it's going to be on clj-commons)

lread 2020-06-25T15:24:07.076300Z

@snoe, rewrite-cljc also brings in the paredit API from rewrite-cljs which might be of interest to you, dunno. https://github.com/lread/rewrite-cljc-playground/blob/master/src/rewrite_cljc/paredit.cljc

1๐Ÿ˜
lread 2020-06-25T15:25:29.077300Z

@borkdude, that would be great!

snoe 2020-06-25T17:48:39.077500Z

https://github.com/snoe/clojure-lsp/pull/150 I'm gonna mull it over, are you waiting on clj-commons before going to clojars?

lread 2020-06-25T19:02:21.077800Z

Ya, I donโ€™t want to confuse with a lread version and then a clj-commons version.

1๐Ÿ‘
slimslenderslacks 2020-06-27T19:28:42.088300Z

@lee awesome, good to hear! That repo contains some code to watch clojars and send PRs to Repos that might need project.clj updates. We're about to release that to the community, along with a few other tools that people will hopefully find useful. One for formatting https://go.atomist.com/catalog/skills/atomist/cljfmt-skill and one for adding clj-kondo https://go.atomist.com/catalog/skills/atomist/clj-kondo-skill are almost ready to go (speaking of rewrite-clj!)

slimslenderslacks 2020-06-27T19:31:10.089100Z

I'm excited to start using rewrite-cljc when it's ready

lread 2020-06-27T19:32:33.090700Z

cool! Iโ€™ll announce when rewrite-cljc is up on clojars. It is open source, so... not sure when, but itโ€™ll get there.

1๐Ÿ‘