Clojurians Log v2

@borkdude (and anyone else with an interest), I have been playing with an implementation of namespaced maps in rewrite-cljc based on our discussions. It is working splendidly in some aspects but I’m finding that it is not working well for the folks who want to traverse the parsed tree. These folks typically use a zipper and expect a node’s children to be a sequence. To illustrate, let’s have a look at the children of a rewrite-clj parsed map:

(require '[rewrite-clj.parser :as p]
         '[rewrite-clj.node :as n])

(n/children (p/parse-string
                      "{
  :a 1
  :b 2}")) 
;; => (<newline: "\n"> <whitespace: "  "> <token: :a> <whitespace: " "> <token: 1> <newline: "\n"> <whitespace: "  "> <token: :b> <whitespace: " "> <token: 2>)

#:my-prefix ,
{ :a 1
  :b 2 }

Ah that makes sense. I have the rewriting perspective less than the parsing perspective.

although I also use rewriting

Also if you feel strongly about the dynamic var in sexpr don't take my opinion on it as absolute. In some other contexts it may be more convenient than having to pass it args. Trade-offs.

Thanks for the feedback @borkdude, much appreciated. > Also if you feel strongly about the dynamic var in sexpr don’t take my opinion on it as absolute. In some other contexts it may be more convenient than having to pass it args. Trade-offs. I’ve switched to passing in the namespace auto-resolve fn as in an optional opts arg where it is needed. It works ok for the node api, but a can be a bit awkward for some existing zip api functions (at least one is variadic). I’m thinking in the case of the zip api, I’ll experiment holding the opts in zipper itself.

@lee I now implemented clj-kondo linting inside defrecord and deftype, this should help with rewrite-clj hopefully.

It's on master, but you can try a binary from the builds if you'd like

Awesome @borkdude, thanks! I will give it a try!

$ clj-kondo --lint src
src/rewrite_cljc/node/keyword.cljc:23:12: warning: unused binding this
src/rewrite_cljc/node/namespaced_map.cljc:48:9: warning: unused binding this
src/rewrite_cljc/node/namespaced_map.cljc:51:11: warning: unused binding this
src/rewrite_cljc/node/namespaced_map.cljc:62:12: warning: unused binding this
src/rewrite_cljc/node/reader_macro.cljc:70:11: warning: unused binding this
src/rewrite_cljc/node/seq.cljc:15:9: warning: unused binding this
src/rewrite_cljc/node/seq.cljc:18:11: warning: unused binding this
src/rewrite_cljc/node/seq.cljc:22:12: warning: unused binding this

seems to work :)

Love it!