rewrite-clj

https://github.com/clj-commons/rewrite-clj
lread 2021-02-19T18:17:49.009500Z

Due to circumstances beyond my control, I was at 0 borks on the borkdude productivity meter for the last week, but am back at the keyboard and back to working toward rewrite-clj v1.

🎉 3
borkdude 2021-02-19T18:18:51.010900Z

No borks given :)

lread 2021-02-19T18:19:02.011100Z

Ha!

vemv 2021-02-19T18:19:21.011500Z

not even one nanobork?

lread 2021-02-19T18:20:14.012400Z

I usually operate at steady 0.1 borks, but this last week, it was a flat 0 borks weeks.

borkdude 2021-02-19T18:20:27.012700Z

Hammock week

lread 2021-02-19T18:23:51.015500Z

I’m looking at my old TODOs in rewrite-clj and uncovered a few items around the regex node. One of them has me waffling. Calling sexpr on a regex node currently returns (list 're-pattern string-pattern) . I’m wondering if it should return an actual regex, as in (re-pattern string-pattern) .

lread 2021-02-19T18:24:51.016500Z

Or maybe this might be more troubling than helpful for the rewrite-clj user due to diffs in regex for clj and cljs.

lread 2021-02-19T18:26:39.017900Z

Given that none have complained about current sexpr behaviour on regex nodes yet, I suppose that is an argument for not changing it…

lread 2021-02-19T18:29:27.018400Z

Yeah, I think I should probably leave sexpr on regex node as is for now.

lread 2021-02-19T18:29:37.018700Z

I am glad we had this little talk.

borkdude 2021-02-19T18:31:39.019Z

:duckie:

3
2021-02-19T18:49:54.019400Z

@lee as I lost a lot of time trying to use cljs.analyzer then realizing that it does not fit my needs, I might implement further versions of my tool based on rewrite-clj + custom analyzer. Let me know if you need any tester for the v1.

lread 2021-02-19T18:57:04.019600Z

I also wasted a TON (is an all-caps ton heavier?) of time implementing potemkin import-vars in cljs which I’m going to abandon (which meant lots of time with cljs.analyzer). But… I also learned a TON, so, in the end I’m cool with the adventure.

2021-02-19T19:07:08.019900Z

That was also a good experience for myself as well, i learned how to improve Minimallist in the process.

lread 2021-02-19T19:42:22.020100Z

Awesome!