Clojurians Log v2
rewrite-clj
Congratulations on the release! 🎉 I'll make some local tests with clojure-lsp soon
Awesome, thanks @ericdallo !
Welcome @nate !
hey! looking forward to following the project
I'm especially hopeful for a babashka pod at some point, but definitely no pressure
thanks for taking up the banner
It’s been enriching!
And @nwjsmith !
@nate Currently a pod isn't possible since the rewrite-clj AST isn't serializable. I'm having thoughts about a separate rewrite-clj scripting CLI.
Thanks for the rewrite-clj v1 tweet announce and kind words therein @borkdude!
2❤️@lee Btw you may want to make these tags proper release on Github? https://github.com/clj-commons/rewrite-clj/releases
Else they won't show up on the front page
Hmm… thanks, will look into it!
It seems clojure-lsp is working with rewrite-clj alpha release 😄
Why zip/value is deprecated?
Checking the docstring doesn't point to any replacement
Yeah, was just verifying zip/value, https://github.com/clj-commons/rewrite-clj/blob/6b359d62ec5bad7d4afe848cd15d116b542c4212/src/rewrite_clj/zip/base.clj#L61. It is really just a call to node.value https://github.com/clj-commons/rewrite-clj/blob/6b359d62ec5bad7d4afe848cd15d116b542c4212/src/rewrite_clj/node.clj#L115.
I’ll update the note on zip/value docstring.
Thanks! probably https://github.com/clj-commons/rewrite-clj/blob/6b359d62ec5bad7d4afe848cd15d116b542c4212/src/rewrite_clj/zip/base.clj#L83`zip/string` ?
Or zip/sexpr , whichever makes more sense in your specific use case. The nice thing about zip/string, if it works for your case, is that it always works.
yeah, we use z/sexpr in a lot of places but there are places where the string makes sense
thanks for the help and your work! I'll keep testing the release for a few days, then I'll check if it fixes some clojure-lsp issues with cljs 🤞
Awesome, thanks for giving it a good shake!
The only thing that broke something for me so far is that rewrite-clj v1 preserves, if it exists, a newline at end of input, some of my code that used rewrite-clj v0 was not expecting that, so I had to adjust. Wasn’t hard - but a minor incompatibility.
Good to know! I'll keep an eye on that