rewrite-clj

https://github.com/clj-commons/rewrite-clj
mauricio.szabo 2021-05-06T17:27:18.258800Z

Hi there! I'm currently in the process of migrating Chlorine/Clover to rewrite-clj instead of rewrite-cljs. There are some issues I'm seeing with Shadow-CLJS, for example, errors like:

rewrite-clj.node.protocols/value is deprecated
I'm literally only importing rewrite-clj.node...

borkdude 2021-05-06T17:37:57.259200Z

@mauricio.szabo Does this happen only because of the require, or are you using some macro maybe?

mauricio.szabo 2021-05-06T17:43:46.259600Z

No, I only required the namespace.

borkdude 2021-05-06T18:23:10.261300Z

Not sure why it does that. Maybe @thheller in #shadow-cljs knows?

lread 2021-05-06T18:42:00.262600Z

@mauricio.szabo, @pez https://github.com/weavejester/cljfmt/issues/224. Is this the kind of thing you are seeing too?

mauricio.szabo 2021-05-06T18:57:31.263300Z

Yes, exactly. I'm seeing the same error: I try to import the namespace, it fails with this errors

lread 2021-05-06T20:37:22.263900Z

@mauricio.szabo, fails or warns?

mauricio.szabo 2021-05-06T23:53:27.264100Z

Warns, but on shadow-cljs by default it'll not compile with warnings, so it's almost the same as a fail :D

mauricio.szabo 2021-05-06T23:54:26.264200Z

BTW, I changed my config to ignore warnings for deprecated functions, and it works. But as what I'm writing is a library, this can pose a problem for people consuming it...