Clojurians Log v2
Clojure programming
Channels
Apps
rum
Simple, decomplected, isomorphic HTML UI library for Clojure and ClojureScript | 0.12.8 https://github.com/tonsky/rum/blob/gh-pages/CHANGELOG.md#0128
grumplet 2017-09-20T09:05:34.000177Z
@arkh - Yes I think that is the problem, but the gist of the react documentation on this seems to be that the application should be responsible for cleaning this sort of thing up. (Rather than library support, I suspect.)
grumplet 2017-09-20T09:05:40.000440Z
https://facebook.github.io/react/blog/2015/12/16/ismounted-antipattern.html
2017-09-20T14:56:45.000286Z
We’ll fix that on Rum side, hopefully before v16 release. @arkh is right it’s because rendering is asynchronous and we build our own queue for rendering, there might be unmounts happening before component is forced to render. This actually happens, so “just removing this check” is not an option
2017-09-20T14:57:32.000250Z
in fact, if you remove it you’ll just get different warning though :)
2017-09-20T15:02:22.000035Z
isMounted is only deprecated for user code, it’s use is completely fine inside Rum. Unfortunately you can’t tell it to React, so we’ll have to re-implement it
grumplet 2017-09-20T19:14:07.000367Z
@tonsky OK, thanks for explaining things. Good to know.