Clojurians Log v2

Hello @thheller, I simplify the code in the same repo, could you help to have a look? Thanks: https://github.com/kimim/shadow-mui

Hello, How can I conditionally use different :source-paths for dev and release? thanks.

@kimi.im with shadow-cljs.edn you can't. I consider this an anti-pattern that should be avoided so its not supported out of the box. you can do it when using deps.edn or project.clj if you really need to

can you get rid of all the server-side code and just use :dev-http static webserver? the server parts are the confusing bits for me

then I should use two different files in the same source path for dev and prod? Is that ok?

what are you trying to do? what do you mean by "two different files"?

this is usually an anti-pattern in shadow-cljs because it does things differently then other tools. so the problem that this pattern is trying to fixed is already fixed. see https://code.thheller.com/blog/shadow-cljs/2018/02/08/problem-solved-source-paths.html

Hi, the REPL problem we discussed occured to me right now and I noticed the following output in browser console:

sorry I talk to too many people. which problem? 😛

that looks like a regular repl load sequence so I don't see the issue?

I don’t how to create client only SPA. Thank you for your reminds. I will try :dev-http

you just take out everything that talks to the server

Server parts are removed now.

so I upgraded the shadow-cljs version in lein-shadow to 2.11.10 so both variants use the same version

and they look exactly the same then

you can add :js-options {:entry-keys ["browser" "main"]} to your build config which appears to make it work

why I can't quite tell. looks like something in material-ui behaves differently when using "module" as well

Thank you. I just realized that these two branches use different version of shadow-cljs, sorry for this.

the bug where requires are lost, occurs sometimes

[reposting the original report] Hi, it happens to me quite frequently (several times every day) that while doing changes in the code, Shadow-cljs REPL stops working correctly and I have to restart Shadow to make it working again. [4:09 PM] For instance, I get the following in Cursive nREPL:

(clojure.string/join ["ab" "cd"])
Timeout while waiting for result.

[2020-12-16 16:07:58.625 - WARNING] :shadow.cljs.devtools.server.util/handle-ex - {:msg {:op :cljs-load-sources, :sources [[:shadow.build.classpath/resource "cljs/spec/gen/alpha.cljs"] [:shadow.build.classpath/resource "cljs/spec/alpha.cljs"] [:shadow.build.classpath/resource "cljs/repl.cljs"] [:shadow.cljs.repl/resource "cljs/user.cljs"]], :call-id 6, :from 71}}
ExceptionInfo no output for id: [:shadow.cljs.repl/resource "cljs/user.cljs"] {:resource-id [:shadow.cljs.repl/resource "cljs/user.cljs"]}
        shadow.build.data/get-output! (data.clj:197)
        shadow.build.data/get-output! (data.clj:193)
        shadow.cljs.devtools.server.worker.impl/fn--15184/fn--15187 (impl.clj:813)
        clojure.core/map/fn--5866 (core.clj:2753)
        clojure.lang.LazySeq.sval (LazySeq.java:42)
        clojure.lang.LazySeq.seq (LazySeq.java:51)
        clojure.lang.RT.seq (RT.java:535)
        clojure.core/seq--5402 (core.clj:137)
        clojure.core.protocols/seq-reduce (protocols.clj:24)
        clojure.core.protocols/fn--8146 (protocols.clj:75)
        clojure.core.protocols/fn--8146 (protocols.clj:75)
        clojure.core.protocols/fn--8088/G--8083--8101 (protocols.clj:13)

(require '[orgpad.client.db.get :as db-get])
=> nil

------ WARNING - :undeclared-ns ------------------------------------------------
 Resource: <eval>:1:2
 No such namespace: db-get, could not locate db_get.cljs, db_get.cljc, or JavaScript source providing "db-get" (Please check that namespaces with dashes use underscores in the ClojureScript file name)
--------------------------------------------------------------------------------

------ WARNING - :undeclared-var -----------------------------------------------
 Resource: <eval>:1:2
 Use of undeclared Var db-get/latest-editor
--------------------------------------------------------------------------------

:js-options {:entry-keys ["browser" "main"]} solve this issue. That’s great!

please open a github issue if you want to get any kind of progress on this. there is far too much going on in slack for me to keep track of it all.

ok, I will do that 🙂

I do remember this now but still don't have a clue what is going on and also still can't reproduce it

seems similar to this maybe https://github.com/thheller/shadow-cljs/issues/788

you should maybe consider removing this and just requiring all the esm code directly

Seems to be related, I will put it there

otherwise you end up with a weird mix of commonjs and esm

material ui is one of those packages that contains 15 different variants on the code in one package

basically you just add an esm path to all requires

so isntead of ["@material-ui/icons/Build" :default Build] you use ["@material-ui/icons/esm/Build" :default Build]

OK, I will try this solution. Thanks very much.

this way is not working: `["@material-ui/icons/Build" :default Build]` to `["@material-ui/icons/esm/Build" :default Build]`

sorry no time to look into this today. guess the old way is fine then.

Yes. :js-options {:entry-keys ["browser" "main"]} this way is fine now. Thank you for your time. It helps a lot.

This might be a super dumb question but I'm not familiar with frontend. I'm using reagent with shadow-cljs, when I do shadow-cljs release should I be able to serve the app just from my browser by opening index.html or will I always need a webserver?

you'll need a webserver. in that index.html will be a reference to your js bundle that the browser will attempt to fetch. without a webserver that fetch will fail

among likely other things like css and images

thats not entirely true. you can load it directly from the filesystem but you are going to be limited in what you are allowed to do since browsers restrict some stuff if loaded from disk

its best to use a server

ok so basically I can't host it on github pages or S3?

yep

i thought github pages and s3 both can do this. that yep meant those things will work? also, netlify makes this amazingly easy

haha didn't see the "can't". just read "can". sorry. yes of course those are fine.

anything that speaks http and knows how to serve files is fine.

hello, I'm trying to use https://github.com/kunukn/react-collapse imported like #?(:cljs ["@kunukn/react-collapse" :default Collapse]) but when it's rendered this happens:

ERROR [com.fulcrologic.fulcro.react.error-boundaries:31] - Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

version is shadow-cljs 2.11.10

likely means that Collapse is nil. might be :as Collapse or :refer (Collapse)

oh, it was :as Collapse

I only tried :refer; didn't even know you could import a whole class like a ns

is there some rule for when that needs to be done? I see export default Collapse in the library, so I thought it'd be a default export

thanks a lot though :)

Yeah, what is the rule? I usually have to make trial and errors haha

see https://shadow-cljs.github.io/docs/UsersGuide.html#_about_default_exports