Clojurians Log v2

Hi everyone, does shadow-cljs handle URL rewriting to support deep-linking into a single-page app? We are hosted on firebase and to perform rewrites we just need to do the following (Note that we actually have two pages. Hopefully that's not an obstacle):

"rewrites": [
      {
        "source": "/",
        "destination": "/index.html"
      }, {
        "source": "**",
        "destination": "/trade.html"
      }
    ]

just use a the local firebase development http server. IIRC it has one? don't need to use the shadow-cljs http server for this.

Is there a way to bundle eg. binary images along with an :npm-module build? Such that I can get a URL to use in eg. an [:img {:src image-url}]? I'm thinking of something like the Webpack(?) bundler(?) that lets one import { default as myImageUrl } from './my-image.png'; in Javascript.

Thanks for the the reply Thomas. My understanding is that the https://firebase.google.com/docs/hosting/test-preview-deploy#test-locally doesn't support hot reloading? Step 4 of https://firebase.google.com/docs/hosting/test-preview-deploy#test-locally says "To update the local URL with changes, refresh your browser."

but you're totally right that I'm able to test deep-linking when I use firebase emulators:start as opposed to

shadow-cljs watch app

those two are completely separate and the HTTP server you use has nothing to do with hot-reloading. that is separate.

no

okay, that's what I thought thanks 🙂

oooh gotcha so I'm supposed to run both at the same time. Thank you!

yes

is there a shadow + StoryBook example around there? the link in Clojureverse seems dead: https://github.com/shadow-cljs/examples/tree/master/cljs-storybook

https://github.com/lilactown/storybook-cljs this is reasonably recent

thanks!

there could be a :target :storybook that outputs everything exactly in the format storybook wants but so far not too many people use storybook it seems

why is the file argument to load-file must be in classpath? https://github.com/thheller/shadow-cljs/blob/e6c7d36dc4a870c0b64286e0b590e69c06c63d43/src/main/shadow/cljs/repl.clj#L296

what does it take to remove that constraint? I suppose it's connected to other part of the code base?

because thats generally what you want for a "build tool", repeatable builds are the focus. so accessing stuff outside the classpath is generally not allowed

why do you care? I mean what files are you trying to load that aren't on the classpath?

I asked because I'm using lispy-mode in emacs (an alternate to paredit) which load some "middleware" which is just a cljs file packaged with lispy-mode itself

currently lispy-mode can't work with shadow because it use cider to load the said cljs file when starting up lispy

and I see repl-load-file* thow exception that the file is not in class path

hmm yeah thats a problem

so what does it take to fix? I suppose it may break the api or make some errors become uncaught?

replacing this throw with an impl that supports files outside the classpath https://github.com/thheller/shadow-cljs/blob/e6c7d36dc4a870c0b64286e0b590e69c06c63d43/src/main/shadow/cljs/repl.clj#L294

basically the same as the impl below that, just without all the classpath references

will be kinda hard without understanding how all of it works internally 😛

feel free to open an issue about this. can't get to it right now but maybe over the weekend

yes, I will. I'm trying to make a PR anyway...

thank you very much

might see more adoption if the integration would be that trivial?

the example doesn’t work anymore:

TypeError: Cannot read property 'CLOSURE_UNCOMPILED_DEFINES' of undefined

hmm yeah storybook changes a lot. kinda switches how everythingthing works every version. haven't looked at it recently.