I'm sure I can give it a spin today/tomorrow.
Seems to work okay for me, my application is working as expected.
I wouldn't expect any of the changes to break existing code but good to have it confirmed. I think @fabrao is the only person to try the multiple result sets feature so far and maybe @somedude314 could try the changes to find-by-keys
...
Maybe @antonmos could test the foldable stuff?
Will do
Yup, first thing tomorrow!
@seancorfield Worked flawlessly during manual testing:
user=> (sql/find-by-keys ds :user {:email "<mailto:test@example.com|test@example.com>"} {:table-fn ansi :column-fn ansi :columns [:email]})
[#:user{:email "<mailto:test@example.com|test@example.com>"}]
user=> (sql/find-by-keys ds :user {:email "<mailto:test@example.com|test@example.com>"} {:table-fn ansi :column-fn ansi :columns [:email :role]})
[#:user{:email "<mailto:test@example.com|test@example.com>", :role "parent"}]
user=> (sql/get-by-id ds :user #uuid"a6980a75-842f-4e4b-8328-fcf1166d69be" {:table-fn ansi :column-fn ansi :columns [:email :role]})
#:user{:email "<mailto:test@example.com|test@example.com>", :role "parent"}
user=> (sql/get-by-id ds :user #uuid"a6980a75-842f-4e4b-8328-fcf1166d69be" {:table-fn ansi :column-fn ansi :columns [[:email :whaaat] :role]})
#:user{:whaaat "<mailto:test@example.com|test@example.com>", :role "parent"}
user=> (sql/find-by-keys ds :user {:email "<mailto:test@example.com|test@example.com>"} {:table-fn ansi :column-fn ansi :columns [[:email :cool] :role]})
[#:user{:cool "<mailto:test@example.com|test@example.com>", :role "parent"}]
user=> (sql/find-by-keys ds :user :all {:table-fn ansi :column-fn ansi :columns [[:email :cool] :role]})
[#:user{:cool "<mailto:test2@example.com|test2@example.com>", :role "teacher"} #:user{:cool "<mailto:test@example.com|test@example.com>", :role "parent"}]
user=> (sql/find-by-keys ds :user :all {:fetch 1 :table-fn ansi :column-fn ansi :columns [[:email :cool] :role]})
[#:user{:cool "<mailto:test2@example.com|test2@example.com>", :role "teacher"}]
user=> (sql/find-by-keys ds :user :all {:offset 1 :fetch 1 :table-fn ansi :column-fn ansi :columns [[:email :cool] :role]})
[#:user{:cool "<mailto:test@example.com|test@example.com>", :role "parent"}]
Nice! Thanks @somedude314
You bet. Thanks for the amazing work.