test-check

nwjsmith 2017-11-18T18:18:56.000126Z

@gfredericks The patch ended up being much smaller that I had thought https://gist.github.com/nwjsmith/edd1ce97b9e5334ac3cbc49a77ffb339 I'm trying to track down the other part of that ticket though. I can't seem to find any reader conditionals related to :/ in the tests. Did that already get fixed up?

2017-11-18T18:19:34.000095Z

@nwjsmith do you have the latest master?

nwjsmith 2017-11-18T18:20:37.000027Z

🤦

nwjsmith 2017-11-18T18:20:43.000078Z

I see it now

nwjsmith 2017-11-18T18:33:38.000009Z

I've attached the patch to the ticket. Do I need to fiddle with the JIRA workflow of the ticket at all?

2017-11-18T18:36:53.000030Z

No -- you got both of the :/ things?

nwjsmith 2017-11-18T18:43:52.000035Z

Yeah, both of the keyword-symbol-serialization-roundtrip and edn-roundtrips tests

nwjsmith 2017-11-18T18:44:00.000011Z

and they both pass

2017-11-18T19:13:18.000018Z

cool, taking a look now

2017-11-18T19:25:27.000050Z

@nwjsmith looks great! will push as soon as the tests pass on my end and then close the ticket thanks again

nwjsmith 2017-11-18T19:37:28.000047Z

No problem. Thanks for your help and let me know if there's anything else you'd like me to take a crack at

2017-11-18T19:41:38.000155Z

TCHECK-125 looks manageable, if you're interested

👍 1
2017-11-18T19:42:37.000054Z

I'd wrap all the defmethods in an if that checks if clojure.test/report is a MultiFn or whatever that class is, and if it's not then just print a warning to *err*