Clojurians Log v2

com.github.seancorfield/clj-new {:mvn/version "1.1.264"} -- Create new applications and libraries with the Clojure CLI -- https://github.com/seancorfield/clj-new/releases/tag/v1.1.264 -- adjusts all generated projects so they follow the Clojars policy change to Verified Group Names; changes the group ID of clj-new to a VGN (releases will be double-published to seancorfield/clj-new for a while). Follow-up in #clj-new for the library, follow-up in #clojars for the policy

I’m seeing this

/t/deps ❯❯❯ clojure -version
Clojure CLI version 1.10.2.801
/t/deps ❯❯❯ cat deps.edn
{:deps {org.clojure/clojure {:mvn/version "1.10.2"}
        org.clojure/clojurescript {:git/url "<https://github.com/clojure/clojurescript>", :sha "715cdc07dbb1d595af91ea12affb6faf0b615d4b"}}}
/t/deps ❯❯❯ clojure -Stree
Error building classpath. Manifest type not detected when finding deps for org.clojure/clojurescript in coordinate {:git/url "<https://github.com/clojure/clojurescript>", :sha "715cdc07dbb1d595af91ea12affb6faf0b615d4b"}

I can't reproduce that - can you try with -Sforce ?

(git urls typically end in .git btw, although github doesn't seem to require it)

@alexmiller same:

/t/deps ❯❯❯ clojure -Sforce
Error building classpath. Manifest type not detected when finding deps for org.clojure/clojurescript in coordinate {:git/url "<https://github.com/clojure/clojurescript>", :sha "715cdc07dbb1d595af91ea12affb6faf0b615d4b"}

that... does not make any sense to me

(also if I append .git)

the manifest type is pulled from the :git/url ns attribute

(I'm not saying you're not seeing it, just saying I don't understand why)

I’m also a bit puzzled, works for another git dep

anything in your ~/.clojure/deps.edn? Can you try with -Srepro (that will omit that one)

can you attach the actual deps.edn file here

there you go, still reproduces with clojure -Sforce -Srepro for me

$ clojure -Sdeps '{:deps {org.clojure/clojure {:mvn/version "1.10.2"}
        org.clojure/clojurescript {:git/url "<https://github.com/clojure/clojurescript>", :sha "715cdc07dbb1d595af91ea12affb6faf0b615d4b"}}}'

clojure -Srepro -Sdeps '{:deps {org.clojure/clojure {:mvn/version "1.10.2"}
        org.clojure/clojurescript {:git/url "<https://github.com/clojure/clojurescript>", :sha "715cdc07dbb1d595af91ea12affb6faf0b615d4b"}}}'
Error building classpath. Manifest type not detected when finding deps for org.clojure/clojurescript in coordinate {:git/url "<https://github.com/clojure/clojurescript>", :sha "715cdc07dbb1d595af91ea12affb6faf0b615d4b"}

@mkvlr try rm -rf ~/.gitlibs; rm -rf .cpcache

neither of those should be in play here

@borkdude moving ~/.gitlibs away fixed it

🤷

hrm

oh, I'm misreading the error message

@alexmiller I had previously our fork at http://github.com/nextjournal/clojurescript.git of ClojureScript with the same sha in the deps.edn . Let me know if I should try to isolate the issue with ~/.gitlibs and send you a minimal version

this is not detecting a manifest type in the git working tree

it's looking for either deps.edn or pom.xml in the dir

so curious what you see in ~/.gitlibs/libs/org.clojure/clojurescript/715cdc07dbb1d595af91ea12affb6faf0b615d4b

is that maybe an empty dir?

@alexmiller yes, it’s empty

ok, well I understand the error then :)

that (I think) is a side effect of parallel download conflicts from the prior jgit impl

I was never able to repro that so I can't say that it won't happen in the new one (but I think it won't)

Maybe treat an empty dir as non-existing?

That would cover up the cause maybe too much

right now we use the existence of the dir as a signal, but I want to look at this more

anyhow, enqueued :)

thx for trying it and reporting

thank you!

@alexmiller Is there a documented, supported way to get hold of the injected basis for a t.d.a based program? The system property went away, right? I know how to calculate the project basis but that's not necessarily the same.

I guess (t/merge-edns ((juxt :root-edn :user-edn :project-edn) (t/find-edn-maps))) is really all I need (since I'm just trying to look up available aliases, not deps at this point).