is there anyone else that can approve this PR besides tony?
since he's busy
@jasonjckn: all tests passing?
@ethangracer i'll run them now
head has test failure
@jasonjckn: any idea if it was yours?
or do you mean develop
wouldn’t at all be surprised, haven’t been in there for some time
develop HEAD
yes
there's 1 failure
LOG: 'Testing untangled.client.impl.network-spec'
LOG: 'Testing untangled.client.protocol-support-spec'
LOG: 'Testing untangled.client.data-fetch-spec'
Chrome 52.0.2743 (Mac OS X 10.11.6) untangled.client.data-fetch-spec __Query-response-processing--loaded-callback-__G__22594 FAILED
Fail (__Query-response-processing--loaded-callback-__G__22594) (Error:NaN:NaN)
Expected nil
Actual: #object[Error Error: Assert failed: (reconciler? reconciler)]
LOG: 'Testing untangled.client.core-spec'
WARN: ' [ 0.634s] [om.next] merge-state!: component must implement Ident'
`@jasonjckn ok, it's been super busy for me today too but I can get this tomorrow
cool thanks!