untangled

NEW CHANNEL: #fulcro
gardnervickers 2016-09-30T13:23:03.001533Z

@tony.kay Turns out it’s not untangled, thanks for walking through that with me. Turning :pathopt on in the reconciler allows me to recreate this in vanilla Om.next.

anmonteiro 2016-09-30T13:23:33.001534Z

@gardnervickers happy to look at a minimal repro

gardnervickers 2016-09-30T13:26:55.001535Z

@anmonteiro https://gist.github.com/gardnervickers/68ea600676f319d3467d9c3a849439ca That would be very appreciated!

gardnervickers 2016-09-30T13:27:33.001536Z

If you’d like me to put it in a different form let me know

anmonteiro 2016-09-30T13:27:47.001537Z

doesn’t look very minimal to me

gardnervickers 2016-09-30T13:30:40.001538Z

Yea, I’ll strip it down further. The issue only presents when you have a union inside of a union, so there needs to be a few components.

tony.kay 2016-09-30T15:13:07.001541Z

@gardnervickers Cool. Nested unions isn't something I've used yet. Thanks @anmonteiro for continuing to be such a valuable resource to the community!

2016-09-30T15:24:22.001542Z

@gardnervickers @anmonteiro we have been using nested unions extensively and haven’t had any issues apart from making sure it’s all hooked up correctly. We’ve definitely seen the no queries for component path error a fair bit, not just with unions. We think it happens when we transact with a follow-on read intended to re-render a component that isn't on the screen when the transaction is called

2016-09-30T15:25:26.001544Z

of course, it’s very possible there is still an issue with unions, just sharing what we’ve encountered

tony.kay 2016-09-30T15:26:13.001545Z

Hm. That would make sense, and would be a different kind of bug...it should be safe to ask for a re-render of something that isn't on screen...it should be a harmless no-op

tony.kay 2016-09-30T15:26:31.001546Z

sounds like it only happens when pathopt is on (which it is in Untangled)

gardnervickers 2016-09-30T15:31:56.001547Z

The issue we’re seeing is specifically with om/full-query choking on the path. I’ve refined my repro quite a bit more, and am still working on getting it down to a minimal case. https://gist.github.com/gardnervickers/68ea600676f319d3467d9c3a849439ca The issue only appears when there’s an ident on the top level join.

gardnervickers 2016-09-30T15:32:56.001548Z

Moving this to om channel though, thanks for the help everyone!

tony.kay 2016-09-30T16:54:24.001549Z

welcome

tony.kay 2016-09-30T16:54:27.001550Z

let us know the outcome

mitchelkuijpers 2016-09-30T22:06:20.001553Z

@tony.kay Could I pitch in with the untangled documentation sprint? I am currently very busy with shipping something… But I should have some time next week 🙂

tony.kay 2016-09-30T23:39:46.001556Z

@mitchelkuijpers That would be great!