@wilkerlucio I've already asked our devs to fix their formatting configs.
@tony.kay nice 🙂
@wilkerlucio @mitchelkuijpers @therabidbanana @baris and anyone else thinking of helping with components: I'm going to merge stylekit with components into untangled-ui today. This will enable us to keep the two in sync more easily, and make it easier to work on the shared concern of making the CSS styling into active components. I'll update the README, and try to get at least one component fully written as an example for us to treat as a straw-man for working together on this.
Sounds good. Just watched the video so now I actually get what I signed up for. Nice trick with the syntax quoting for IDE mutation documentation by the way. We've always treated the expansion thing in mutations as a bug instead of harnessing it as a feature. 🙂
thanks. I'm still refining the trick. I don't love defmutation
because of the implicit use of state
and such
at the moment I lean towards a placeholder defn
with the docstring (and a body that is a comment to look at the defmethod below it), and just a real defmethod
for the implementation
(defn do-thing "Om Mutation: ..." [{:keys [thing-id]}] (comment "See defmethod"))
(defmethod m/mutate `do-thing [env k {:keys [thing-id]}] ...)
just because of :remote
and the warnings that the macro causes. A bigger macro could help:
(defmutation do-thing "doc string" [{:keys [thing-id]}]
(action [env] body-of-action)
(remote [env] code-related-to-computing-remote))
would give the IDE advantages and not cause warnings in the defmutation definition AND would allow for remote support
I kind of like the way that looks too.
Makes it more like a defui.
it also prevents you from screwing up and doing the action without the map {:action/:remote}
Something I've done more than once.
me too
if you want to write it, I'll take a PR 😉 otherwise, might get to it in the next few days
the one I wrote already should make it a relatively light task
then again, macros have sucked more than one day out of me when clj/cljs interactions go awry