untangled

NEW CHANNEL: #fulcro
ianchow 2017-05-18T03:07:09.133757Z

does untangled-websockets work with the new, modular untangled-server?

tony.kay 2017-05-18T03:19:53.220435Z

@ianchow Sure. You just have to work the server-side handler into the stack.

tony.kay 2017-05-18T03:20:43.226148Z

@cjmurphy Hm. I’ll pull it down and take a look.

tony.kay 2017-05-18T03:37:24.335149Z

@cjmurphy So, I never got the error you described, but I first made sure the projects deps were clean. There were some problems there. Then, there were some render issues, but everything in the console was clean.

tony.kay 2017-05-18T03:37:43.337202Z

I’m double-checking my fixes to the re-render, but I think your problems were largely project-file based

tony.kay 2017-05-18T03:38:40.343203Z

I’ll send you a PR with the patch in a few mins

tony.kay 2017-05-18T03:45:46.390542Z

So, I think there is a bug in Om. If you try to trigger a re-render on root with a property keyword it doesn’t seem to re-render, though if you use a keyword from a join it is fine.

tony.kay 2017-05-18T03:46:35.395671Z

So, the main thing I did was change the follow-on read where edit is transacted to use :main-ui-router as the follow-on read, and that seems to fix it.

tony.kay 2017-05-18T03:47:50.403809Z

Also, there should not be a need for adding lag where you were adding it

tony.kay 2017-05-18T03:56:01.458342Z

https://github.com/chrismurrph/csv-to-csv/pull/1/files

tony.kay 2017-05-18T03:56:12.459556Z

PR with comments, if anyone else is interested.

cjmurphy 2017-05-18T06:07:22.350891Z

Thanks a lot :simple_smile:

danielgrosse 2017-05-18T10:00:26.332953Z

Hello I working through the youtube videos and currently on the server components. When I reload the page the local-app-state tells me

{:items/by-id {:untangled.client.impl.om-plumbing/not-found {}},
 :ui/locale "en-US",
 :om.next/tables #{:items/by-id},
 :list [:lists/by-title "Initial List"],
 :untangled/loads-in-progress #{},
 :om.next/ready-to-load [],
 :ui/loading-data false,
 :lists/by-title
 {"Initial List"
  {:title "Initial List",
   :ui/new-item-label "",
   :items [:items/by-id :untangled.client.impl.om-plumbing/not-found]}}}
`

danielgrosse 2017-05-18T10:00:52.339733Z

Is it caused by the empty atom, which is initialized at the start?

danielgrosse 2017-05-18T10:02:05.358176Z

Ah found it. I had made an atom with a map and not a vector

tony.kay 2017-05-18T16:45:10.024908Z

@cjmurphy see discussion in #om I just had. I forgot that the follow-on read causes the query to get focused, and since that kw (:ui/react-key) wasn’t changed, the refresh got optimized away.

tony.kay 2017-05-18T16:46:07.046601Z

follow-on reads do two things: look up the components to refresh, AND narrow the re-query to just the things you’ve indicated. If those things don’t change, then no refresh is done (because Om thinks there is nothing to do).

tony.kay 2017-05-18T16:47:18.071983Z

I was (mistakenly) thinking that the narrowing was to the component, but I guess it is all the way down to the specific item in the (sub)query.

cjmurphy 2017-05-18T22:43:44.810321Z

I wonder if there is there any way to by-pass the first part (index lookup) by using an ident/s as the follow on read? I'm saying that because in the past I've had success with using idents for follow on reads. Also (maybe related), is it always the case that something somewhere needs to have changed for a follow on read to re-render?